panel: Fix a JS warning

We need to track the open-status of indicator menus, but don't want
to hook up signals more than once, so we check for the handler ID
we store on the object. As the property is only defined once we did
set up the signal connection, this check now logs a warning. We
can avoid it by checking for the existence of the property rather
than a particular value.

https://bugzilla.gnome.org/show_bug.cgi?id=781471

diff --git a/js/ui/panel.js b/js/ui/panel.js
index 52c89d79cd2ebe7ded3fa9014ba2edfcefb15e05..d9df2618a257ae27b7f06f5293bd2a0903a0f13e 100644 (file)
--- a/js/ui/panel.js
+++ b/js/ui/panel.js
@@ -1160,7 +1160,7 @@ const Panel = new Lang.Class({
     },
 
     _onMenuSet: function(indicator) {
-        if (!indicator.menu || indicator.menu._openChangedId > 0)
+        if (!indicator.menu || indicator.menu.hasOwnProperty('_openChangedId'))
             return;
 
         indicator.menu._openChangedId = indicator.menu.connect('open-state-changed',